hippoz/brainlet
Archived
5
1
Fork 1
Code Issues 6 Pull requests Releases Wiki Activity

feat: add message storage and fetching api #21

Merged
hippoz merged 4 commits from message-history into master 2021-10-03 21:20:29 +03:00
Conversation 1 Commits 4 Files changed 5 +92 -21
hippoz commented 2021-10-02 22:57:59 +03:00
Owner
Copy link

Implementation details:

  • A new SAVE_MESSAGES gateway connection attribute was added. If a user has this attribute set, all messages sent by them will be saved unencrypted :( in the database.

  • An endpoint to fetch messages has been added, however, it only covers the usecase of paging in the desktop app. You specifiy a channel and a field called before (get messages before this channel id)

TODOs:

  • Add a policy which allows server owners to control whether to allow saving messages
  • Add more APIs related to message storage (get specific message, delete, etc.) (superseded by issue #22)
  • Specifically label message storage as an experimental and "dangerous" feature (since the messages are not yet encrypted when stored)
Implementation details: - A new `SAVE_MESSAGES` gateway connection attribute was added. If a user has this attribute set, all messages sent by them will be saved unencrypted :( in the database. - An endpoint to fetch messages has been added, however, it only covers the usecase of paging in the desktop app. You specifiy a `channel` and a field called `before` (get messages before this channel id) TODOs: - [x] Add a policy which allows server owners to control whether to allow saving messages - [x] Add more APIs related to message storage (get specific message, delete, etc.) (superseded by issue #22) - [x] Specifically label message storage as an experimental and "dangerous" feature (since the messages are not yet encrypted when stored)
hippoz added 1 commit 2021-10-02 22:58:01 +03:00
hippoz added 2 commits 2021-10-03 21:09:04 +03:00
hippoz added 1 commit 2021-10-03 21:12:00 +03:00
hippoz changed title from draft: feat: add message storage and fetching api to feat: add message storage and fetching api 2021-10-03 21:19:06 +03:00
hippoz commented 2021-10-03 21:20:21 +03:00
Author
Owner
Copy link

Although not all of the TODOs in this pull request have been fulfilled, I will merge it now. All remaning TODOs will be superseded by an issue in the issue tracker.

Although not all of the TODOs in this pull request have been fulfilled, I will merge it now. All remaning TODOs will be superseded by an issue in the issue tracker.
hippoz merged commit 8984598ade into master 2021-10-03 21:20:29 +03:00
hippoz deleted branch message-history 2021-10-03 21:21:50 +03:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hippoz/brainlet#21
No description provided.
Delete branch "message-history"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?