hippoz/brainlet
Archived
5
1
Fork 1
Code Issues 6 Pull requests Releases Wiki Activity

Add gateway pings #20

Merged
hippoz merged 4 commits from gateway-pings into master 2021-09-08 00:28:28 +03:00
Conversation 0 Commits 4 Files changed 8 +871 -1049
hippoz commented 2021-09-08 00:28:15 +03:00
Owner
Copy link

Implementation:
- HELLO packet now contains pingInterval
- Every pingInterval, the client will send a PING packet
- On the server, the client's session is re-validated every PING

(Potential) issues:
- Client could send a lot of PINGs and overload the server, since token validation is somewhat complex
- Certain invalid token errors (expiration for example) trigger an exception and as such the client is disconnected with a payload handling error instead of an authentication error

Implementation: - HELLO packet now contains `pingInterval` - Every `pingInterval`, the client will send a PING packet - On the server, the client's session is re-validated every PING (Potential) issues: - Client could send a lot of PINGs and overload the server, since token validation is somewhat complex - Certain invalid token errors (expiration for example) trigger an exception and as such the client is disconnected with a payload handling error instead of an authentication error
hippoz added 4 commits 2021-09-08 00:28:17 +03:00
hippoz merged commit aa7c838164 into master 2021-09-08 00:28:28 +03:00
hippoz deleted branch gateway-pings 2021-09-10 23:08:00 +03:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hippoz/brainlet#20
No description provided.
Delete branch "gateway-pings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?